From 7c09db641acd7e6770bebcb8526773bee285bab1 Mon Sep 17 00:00:00 2001
From: Michal Pikulski <michal@foolhardyhorizons.com>
Date: Mon, 10 Nov 2025 12:41:28 +0100
Subject: [PATCH] Only show cards when in actual album

---
 Assets/Scripts/UI/CardSystem/AlbumViewPage.cs | 75 ++++++++++++++++++-
 1 file changed, 72 insertions(+), 3 deletions(-)

diff --git a/Assets/Scripts/UI/CardSystem/AlbumViewPage.cs b/Assets/Scripts/UI/CardSystem/AlbumViewPage.cs
index 8b4796a2..cd5d2b1b 100644
--- a/Assets/Scripts/UI/CardSystem/AlbumViewPage.cs
+++ b/Assets/Scripts/UI/CardSystem/AlbumViewPage.cs
@@ -56,7 +56,7 @@ namespace UI.CardSystem
                 canvasGroup = GetComponent<CanvasGroup>();
             if (canvasGroup == null)
                 canvasGroup = gameObject.AddComponent<CanvasGroup>();
-
+            
             // Hide backdrop initially
             if (cardEnlargedBackdrop != null)
             {
@@ -72,6 +72,17 @@ namespace UI.CardSystem
             // Set up booster pack button listeners
             SetupBoosterButtonListeners();
             
+            // Subscribe to book page flip events
+            if (book != null)
+            {
+                book.OnFlip.AddListener(OnPageFlipped);
+                Debug.Log("[AlbumViewPage] Subscribed to book.OnFlip event");
+            }
+            else
+            {
+                Debug.LogWarning("[AlbumViewPage] Book reference is null, cannot subscribe to OnFlip event!");
+            }
+            
             // Subscribe to CardSystemManager events (managers are guaranteed to be initialized)
             if (CardSystemManager.Instance != null)
             {
@@ -125,6 +136,12 @@ namespace UI.CardSystem
             for (int i = 0; i < boosterPackButtons.Length; i++)
             {
                 if (boosterPackButtons[i] == null) continue;
+            // Unsubscribe from book events
+            if (book != null)
+            {
+                book.OnFlip.RemoveListener(OnPageFlipped);
+            }
+            
                 
                 Button button = boosterPackButtons[i].GetComponent<Button>();
                 if (button != null)
@@ -252,8 +269,16 @@ namespace UI.CardSystem
                 CardSystemManager.Instance.OnPendingCardAdded += OnPendingCardAdded;
             }
             
-            // Spawn pending cards when opening album
-            SpawnPendingCards();
+            // Only spawn pending cards if we're already on an album page (not the menu)
+            if (IsInAlbumProper())
+            {
+                Debug.Log("[AlbumViewPage] Opening directly to album page - spawning cards immediately");
+                SpawnPendingCards();
+            }
+            else
+            {
+                Debug.Log("[AlbumViewPage] Opening to menu page - cards will spawn when entering album");
+            }
             
             base.TransitionIn();
         }
@@ -342,6 +367,50 @@ namespace UI.CardSystem
             }
         }
         
+        /// <summary>
+        /// Check if we're currently viewing the album proper (not the menu page)
+        /// </summary>
+        private bool IsInAlbumProper()
+        {
+            if (book == null)
+            {
+                Debug.LogWarning("[AlbumViewPage] Book reference is null in IsInAlbumProper check");
+                return false;
+            }
+            
+            // Page 1 is the menu/cover, page 2+ are album pages with card slots
+            bool inAlbum = book.CurrentPaper > 1;
+            Debug.Log($"[PAGE-NAV-DEBUG] IsInAlbumProper check - CurrentPage: {book.CurrentPaper}, InAlbum: {inAlbum}");
+            return inAlbum;
+        }
+        
+        /// <summary>
+        /// Called when book page flips - show/hide pending cards based on whether we're in the album proper
+        /// </summary>
+        private void OnPageFlipped()
+        {
+            bool isInAlbum = IsInAlbumProper();
+            
+            Debug.Log($"[PAGE-NAV-DEBUG] OnPageFlipped - CurrentPage: {book.CurrentPaper}, IsInAlbum: {isInAlbum}, CardsCurrentlySpawned: {_activeCards.Count}");
+            
+            if (isInAlbum && _activeCards.Count == 0)
+            {
+                // Entering album proper and no cards spawned yet - spawn them with animation
+                Debug.Log("[AlbumViewPage] Entering album proper - spawning pending cards with animation");
+                SpawnPendingCards();
+            }
+            else if (!isInAlbum && _activeCards.Count > 0)
+            {
+                // Returning to menu page - cleanup cards
+                Debug.Log("[AlbumViewPage] Returning to menu page - cleaning up pending cards");
+                CleanupActiveCards();
+            }
+            else
+            {
+                Debug.Log($"[AlbumViewPage] Page flipped but no card state change needed (already in correct state)");
+            }
+        }
+        
         #region Album Card Reveal System
         
         /// <summary>