Refactor interactions, introduce template-method lifecycle management, work on save-load system #51

tschesky · 2025-11-07T14:36:04Z

tschesky commented

2025-11-07 14:36:04 +00:00

Lifecycle Management & Save System Revamp

Overview

Complete overhaul of game lifecycle management, interactable system, and save/load architecture. Introduces centralized ManagedBehaviour base class for consistent initialization ordering and lifecycle hooks across all systems.

Core Architecture

New Lifecycle System

LifecycleManager: Centralized coordinator for all managed objects
ManagedBehaviour: Base class replacing ad-hoc initialization patterns
- OnManagedAwake(): Priority-based initialization (0-100, lower = earlier)
- OnSceneReady(): Scene-specific setup after managers ready
- Replaces BootCompletionService (deleted)
Priority groups: Infrastructure (0-20) → Game Systems (30-50) → Data (60-80) → UI/Gameplay (90-100)
Editor support: EditorLifecycleBootstrap ensures lifecycle works in editor mode

Unified SaveID System

Consistent format: {ParentName}_{ComponentType}
Auto-registration via AutoRegisterForSave = true
New DebugSaveIds editor tool for inspection

Save/Load Improvements

Enhanced State Management

Extended SaveLoadData: Unlocked minigames, card collection states, combination items, slot occupancy
Async loading: ApplyCardCollectionState() waits for card definitions before restoring
New SaveablePlayableDirector: Timeline sequences save/restore playback state
Fixed race conditions: Proper initialization ordering prevents data corruption

Interactable & Pickup System

Migrated to OnManagedAwake() for consistent initialization
Template method pattern for state restoration (RestoreInteractionState())
Fixed combination item save/load bugs (items in slots vs. follower hand)
Dynamic spawning support for combined items on load
Breaking: Interactable.Awake() now sealed, use OnManagedAwake() instead

UI System Changes

AlbumViewPage and BoosterNotificationDot: Migrated to ManagedBehaviour
Fixed menu persistence bug: Menus no longer reappear after scene transitions
Pause Menu: Now reacts to all scene loads (not just first scene)
Orientation Enforcer: Enforces per-scene via SceneManagementService
Loading Screen: Integrated with new lifecycle

⚠️ Breaking Changes

BootCompletionService removed → Use ManagedBehaviour.OnManagedAwake() with priority
Interactable.Awake() sealed → Override OnManagedAwake() instead
SaveID format changed → Now {ParentName}_{ComponentType} consistently
MonoBehaviours needing init ordering → Must inherit from ManagedBehaviour

# Lifecycle Management & Save System Revamp ## Overview Complete overhaul of game lifecycle management, interactable system, and save/load architecture. Introduces centralized `ManagedBehaviour` base class for consistent initialization ordering and lifecycle hooks across all systems. ## Core Architecture ### New Lifecycle System - **`LifecycleManager`**: Centralized coordinator for all managed objects - **`ManagedBehaviour`**: Base class replacing ad-hoc initialization patterns - `OnManagedAwake()`: Priority-based initialization (0-100, lower = earlier) - `OnSceneReady()`: Scene-specific setup after managers ready - Replaces `BootCompletionService` (deleted) - **Priority groups**: Infrastructure (0-20) → Game Systems (30-50) → Data (60-80) → UI/Gameplay (90-100) - **Editor support**: `EditorLifecycleBootstrap` ensures lifecycle works in editor mode ### Unified SaveID System - Consistent format: `{ParentName}_{ComponentType}` - Auto-registration via `AutoRegisterForSave = true` - New `DebugSaveIds` editor tool for inspection ## Save/Load Improvements ### Enhanced State Management - **Extended SaveLoadData**: Unlocked minigames, card collection states, combination items, slot occupancy - **Async loading**: `ApplyCardCollectionState()` waits for card definitions before restoring - **New `SaveablePlayableDirector`**: Timeline sequences save/restore playback state - **Fixed race conditions**: Proper initialization ordering prevents data corruption ## Interactable & Pickup System - Migrated to `OnManagedAwake()` for consistent initialization - Template method pattern for state restoration (`RestoreInteractionState()`) - Fixed combination item save/load bugs (items in slots vs. follower hand) - Dynamic spawning support for combined items on load - **Breaking**: `Interactable.Awake()` now sealed, use `OnManagedAwake()` instead ## UI System Changes - **AlbumViewPage** and **BoosterNotificationDot**: Migrated to `ManagedBehaviour` - **Fixed menu persistence bug**: Menus no longer reappear after scene transitions - **Pause Menu**: Now reacts to all scene loads (not just first scene) - **Orientation Enforcer**: Enforces per-scene via `SceneManagementService` - **Loading Screen**: Integrated with new lifecycle ## ⚠️ Breaking Changes 1. **`BootCompletionService` removed** → Use `ManagedBehaviour.OnManagedAwake()` with priority 2. **`Interactable.Awake()` sealed** → Override `OnManagedAwake()` instead 3. **SaveID format changed** → Now `{ParentName}_{ComponentType}` consistently 4. **MonoBehaviours needing init ordering** → Must inherit from `ManagedBehaviour`

tschesky added 13 commits 2025-11-07 14:36:04 +00:00

Rework of base interactables and managed behaviors f88bd0e2c9

Cleanup branch work 3e835ed3b8

SaveLoad using managed lifecycle b932be2232

Work on state machines 15fe4bdce6

Further updates to state machines 210823344a

Last improvements on the save front c527ba334d

Fix issues with puzzle loading order and add saving state when using Menu 717deee0cd

Minor reset fixes 0204c11560

The forgotten push cd12c344a9

REbase changes, update issues with BootCompletionService ba55daa3a7

WOrking card save loads 8c940f4444