Files
AppleHillsProduction/Assets/Scripts/CardSystem/Controllers/CardEnlargeController.cs
tschesky 235fa04eba Merge a card refresh (#59)
- **Refactored Card Placement Flow**
  - Separated card presentation from orchestration logic
  - Extracted `CornerCardManager` for pending card lifecycle (spawn, shuffle, rebuild)
  - Extracted `AlbumNavigationService` for book page navigation and zone mapping
  - Extracted `CardEnlargeController` for backdrop management and card reparenting
  - Implemented controller pattern (non-MonoBehaviour) for complex logic
  - Cards now unparent from slots before rebuild to prevent premature destruction

- **Improved Corner Card Display**
  - Fixed cards spawning on top of each other during rebuild
  - Implemented shuffle-to-front logic (remaining cards occupy slots 0→1→2)
  - Added smart card selection (prioritizes cards matching current album page)
  - Pending cards now removed from queue immediately on drag start
  - Corner cards rebuild after each placement with proper slot reassignment

- **Enhanced Album Card Viewing**
  - Added dramatic scale increase when viewing cards from album slots
  - Implemented shrink animation when dismissing enlarged cards
  - Cards transition: `PlacedInSlotState` → `AlbumEnlargedState` → `PlacedInSlotState`
  - Backdrop shows/hides with card enlarge/shrink cycle
  - Cards reparent to enlarged container while viewing, return to slot after

- **State Machine Improvements**
  - Added `CardStateNames` constants for type-safe state transitions
  - Implemented `ICardClickHandler` and `ICardStateDragHandler` interfaces
  - State transitions now use cached property indices
  - `BoosterCardContext` separated from `CardContext` for single responsibility

- **Code Cleanup**
  - Identified unused `SlotContainerHelper.cs` (superseded by `CornerCardManager`)
  - Identified unused `BoosterPackDraggable.canOpenOnDrop` field
  - Identified unused `AlbumViewPage._previousInputMode` (hardcoded value)
  - Identified unused `Card.OnPlacedInAlbumSlot` event (no subscribers)

Co-authored-by: Michal Pikulski <michal.a.pikulski@gmail.com>
Co-authored-by: Michal Pikulski <michal@foolhardyhorizons.com>
Reviewed-on: #59
2025-11-18 08:40:59 +00:00

129 lines
4.6 KiB
C#

using Core;
using UI.CardSystem.StateMachine;
using UnityEngine;
namespace UI.CardSystem
{
/// <summary>
/// Manages card enlarge system: backdrop display and card reparenting.
/// Created and owned by AlbumViewPage (not a Unity component).
/// </summary>
public class CardEnlargeController
{
private readonly GameObject _backdrop;
private readonly Transform _enlargedContainer;
/// <summary>
/// Constructor - called by AlbumViewPage's lazy property
/// </summary>
public CardEnlargeController(GameObject backdrop, Transform enlargedContainer)
{
_backdrop = backdrop;
_enlargedContainer = enlargedContainer;
}
/// <summary>
/// Subscribe to a placed card's enlarged state events
/// </summary>
public void RegisterCard(StateMachine.Card card)
{
if (card == null) return;
var enlargeState = card.GetStateComponent<StateMachine.States.CardAlbumEnlargedState>(CardStateNames.AlbumEnlarged);
if (enlargeState != null)
{
enlargeState.OnEnlargeRequested += OnCardEnlargeRequested;
enlargeState.OnShrinkRequested += OnCardShrinkRequested;
}
}
/// <summary>
/// Unsubscribe from a card's enlarged state events
/// </summary>
public void UnregisterCard(StateMachine.Card card)
{
if (card == null) return;
var enlargeState = card.GetStateComponent<StateMachine.States.CardAlbumEnlargedState>(CardStateNames.AlbumEnlarged);
if (enlargeState != null)
{
enlargeState.OnEnlargeRequested -= OnCardEnlargeRequested;
enlargeState.OnShrinkRequested -= OnCardShrinkRequested;
}
}
/// <summary>
/// Clean up enlarged card state (on page close)
/// </summary>
public void CleanupEnlargedState()
{
// Hide backdrop if visible
if (_backdrop != null && _backdrop.activeSelf)
{
_backdrop.SetActive(false);
}
// If there's an enlarged card in the container, return it to its slot
if (_enlargedContainer != null && _enlargedContainer.childCount > 0)
{
for (int i = _enlargedContainer.childCount - 1; i >= 0; i--)
{
Transform cardTransform = _enlargedContainer.GetChild(i);
var card = cardTransform.GetComponent<StateMachine.Card>();
var state = cardTransform.GetComponentInChildren<StateMachine.States.CardAlbumEnlargedState>(true);
if (card != null && state != null)
{
Transform originalParent = state.GetOriginalParent();
if (originalParent != null)
{
cardTransform.SetParent(originalParent, true);
cardTransform.localPosition = state.GetOriginalLocalPosition();
cardTransform.localRotation = state.GetOriginalLocalRotation();
}
}
}
}
}
#region Event Handlers
private void OnCardEnlargeRequested(StateMachine.States.CardAlbumEnlargedState state)
{
if (state == null) return;
// Show backdrop
if (_backdrop != null)
{
_backdrop.SetActive(true);
}
// Reparent card root to enlarged container preserving world transform
if (_enlargedContainer != null)
{
var ctx = state.GetComponentInParent<StateMachine.CardContext>();
if (ctx != null)
{
ctx.RootTransform.SetParent(_enlargedContainer, true);
ctx.RootTransform.SetAsLastSibling();
}
}
}
private void OnCardShrinkRequested(StateMachine.States.CardAlbumEnlargedState state)
{
if (state == null) return;
// Hide backdrop; state will animate back to slot and reparent on completion
if (_backdrop != null)
{
_backdrop.SetActive(false);
}
// Do not reparent here; reverse animation is orchestrated by the state
}
#endregion
}
}