tschesky/AppleHillsProduction
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge a card refresh #59

Merged
tschesky merged 19 commits from cards_rewrite into main 2025-11-18 08:40:59 +00:00
Conversation 0 Commits 19 Files Changed 161 +18057 -5743
tschesky commented 2025-11-18 08:40:48 +00:00
Owner
Copy Link

  • Refactored Card Placement Flow

    • Separated card presentation from orchestration logic
    • Extracted CornerCardManager for pending card lifecycle (spawn, shuffle, rebuild)
    • Extracted AlbumNavigationService for book page navigation and zone mapping
    • Extracted CardEnlargeController for backdrop management and card reparenting
    • Implemented controller pattern (non-MonoBehaviour) for complex logic
    • Cards now unparent from slots before rebuild to prevent premature destruction

  • Improved Corner Card Display

    • Fixed cards spawning on top of each other during rebuild
    • Implemented shuffle-to-front logic (remaining cards occupy slots 0→1→2)
    • Added smart card selection (prioritizes cards matching current album page)
    • Pending cards now removed from queue immediately on drag start
    • Corner cards rebuild after each placement with proper slot reassignment

  • Enhanced Album Card Viewing

    • Added dramatic scale increase when viewing cards from album slots
    • Implemented shrink animation when dismissing enlarged cards
    • Cards transition: PlacedInSlotState → AlbumEnlargedState → PlacedInSlotState
    • Backdrop shows/hides with card enlarge/shrink cycle
    • Cards reparent to enlarged container while viewing, return to slot after

  • State Machine Improvements

    • Added CardStateNames constants for type-safe state transitions
    • Implemented ICardClickHandler and ICardStateDragHandler interfaces
    • State transitions now use cached property indices
    • BoosterCardContext separated from CardContext for single responsibility

  • Code Cleanup

    • Identified unused SlotContainerHelper.cs (superseded by CornerCardManager)
    • Identified unused BoosterPackDraggable.canOpenOnDrop field
    • Identified unused AlbumViewPage._previousInputMode (hardcoded value)
    • Identified unused Card.OnPlacedInAlbumSlot event (no subscribers)
- **Refactored Card Placement Flow** - Separated card presentation from orchestration logic - Extracted `CornerCardManager` for pending card lifecycle (spawn, shuffle, rebuild) - Extracted `AlbumNavigationService` for book page navigation and zone mapping - Extracted `CardEnlargeController` for backdrop management and card reparenting - Implemented controller pattern (non-MonoBehaviour) for complex logic - Cards now unparent from slots before rebuild to prevent premature destruction - **Improved Corner Card Display** - Fixed cards spawning on top of each other during rebuild - Implemented shuffle-to-front logic (remaining cards occupy slots 0→1→2) - Added smart card selection (prioritizes cards matching current album page) - Pending cards now removed from queue immediately on drag start - Corner cards rebuild after each placement with proper slot reassignment - **Enhanced Album Card Viewing** - Added dramatic scale increase when viewing cards from album slots - Implemented shrink animation when dismissing enlarged cards - Cards transition: `PlacedInSlotState` → `AlbumEnlargedState` → `PlacedInSlotState` - Backdrop shows/hides with card enlarge/shrink cycle - Cards reparent to enlarged container while viewing, return to slot after - **State Machine Improvements** - Added `CardStateNames` constants for type-safe state transitions - Implemented `ICardClickHandler` and `ICardStateDragHandler` interfaces - State transitions now use cached property indices - `BoosterCardContext` separated from `CardContext` for single responsibility - **Code Cleanup** - Identified unused `SlotContainerHelper.cs` (superseded by `CornerCardManager`) - Identified unused `BoosterPackDraggable.canOpenOnDrop` field - Identified unused `AlbumViewPage._previousInputMode` (hardcoded value) - Identified unused `Card.OnPlacedInAlbumSlot` event (no subscribers)
tschesky added 19 commits 2025-11-18 08:40:48 +00:00
Update the card kerfufle 1fdff3450b
Add roadmap docs 4fdbbb0aa8
Make cards use settings a6471ede45
Fix up card flows, align with the old 1:1 39d5890db4
Stash half-assed work on testing scene 4e7f774386
Updates to card testing scene 755082c67d
Stash scene changes b2c47d4e4f
Updates to testing scene 6fe7d012fc
Almost working card state machine 78aafb9275
Stash work 7aca1a17ac
Update pages to follow new card flow ee07d89d3e
Update assets, working save kerfuffle c6f635f871
Stash work! b5364a2bbc
Working bottom-corner card display e18f1b9963
Finalize nice animations 689e177c99
Working refactor of cleaned up card structure 64c304bb6d
Stash factoring out functionality out of album view page 034654c308
Refactor, cleanup code and add documentaiton cf13fb78b5
Clean up docs fc0c3d0df3
tschesky merged commit 235fa04eba into main 2025-11-18 08:40:59 +00:00
tschesky referenced this issue from a commit 2025-11-18 08:41:00 +00:00
Merge a card refresh (#59)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alec damian tschesky
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tschesky/AppleHillsProduction#59
No description provided.
Delete Branch "cards_rewrite"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?