AppleHillsProduction/docs/common_trajectory_preview_complete.md

✅ Common Trajectory Preview Implementation Complete

Summary

Created a single common TrajectoryPreview component that both FortFight and Airplane minigames now use. The base DragLaunchController class holds the trajectory preview reference and handles all visual feedback automatically.

---

What Was Accomplished

1. Created Common TrajectoryPreview Component ✅

File: Assets/Scripts/Common/Visual/TrajectoryPreview.cs

Features:

• Single, reusable component for all slingshot mechanics
• Multiple API overloads for different use cases
• LineRenderer-based visualization
• Trajectory locking support (show path after launch)
• Ground detection
• Configurable appearance (color, width, points, timeStep)

API Overloads:

// 1. Most explicit - pass everything
UpdateTrajectory(Vector2 startPos, Vector2 velocity, float gravity)

// 2. From launch parameters
UpdateTrajectory(Vector2 startPos, Vector2 direction, float force, float mass, float gravity)

// 3. From prefab Rigidbody2D (RECOMMENDED - auto-reads physics)
UpdateTrajectory(Vector2 startPos, Vector2 direction, float force, GameObject prefab)

2. Updated DragLaunchController Base Class ✅

Added:

• protected TrajectoryPreview trajectoryPreview field
• Auto-finds TrajectoryPreview component if not assigned
• Default implementations of ShowPreview(), HidePreview(), UpdateVisuals()
• Base class handles ALL trajectory logic automatically

How It Works:

// Base class in UpdateDrag():
UpdateVisuals(currentPosition, direction, force, dragDistance, mass);

// Default UpdateVisuals implementation:
protected virtual void UpdateVisuals(...)
{
    if (trajectoryPreview != null && dragDistance > 0.1f)
    {
        GameObject prefab = GetProjectilePrefab();
        trajectoryPreview.UpdateTrajectory(launchAnchor.position, direction, force, prefab);
    }
}

3. Simplified FortFight SlingshotController ✅

Removed:

• private TrajectoryPreview trajectoryPreview field (now in base)
• ShowPreview() override (base handles it)
• HidePreview() override (base handles it)
• UpdateVisuals() override (base handles it)
• OnManagedStart() method (base handles trajectory init)

Code Reduction: ~50 lines removed

Still Has:

• Ammo system
• AI methods
• Trajectory locking (calls trajectoryPreview.LockTrajectory() after launch)

4. Simplified Airplane LaunchController ✅

Removed:

• private LineRenderer trajectoryLine field
• private GameObject anchorVisual field
• Entire Visual Feedback region (~100 lines)
• UpdateTrajectoryPreview() private method (~30 lines)
• ShowPreview() override
• HidePreview() override
• UpdateVisuals() override

Code Reduction: ~130 lines removed

Now Uses: Base class default implementations exclusively

---

Architecture

TrajectoryPreview (Common.Visual)
    ├── LineRenderer component
    ├── Multiple UpdateTrajectory() overloads
    ├── Show() / Hide() / LockTrajectory()
    └── Kinematic trajectory calculation

DragLaunchController (Common.Input)
    ├── protected TrajectoryPreview trajectoryPreview
    ├── Auto-finds component
    ├── Default implementations:
    │   ├── ShowPreview() → trajectoryPreview?.Show()
    │   ├── HidePreview() → trajectoryPreview?.Hide()
    │   └── UpdateVisuals() → trajectoryPreview.UpdateTrajectory(...)
    └── Children can override if needed

SlingshotController (FortFight)
    ├── Uses inherited trajectoryPreview
    ├── No trajectory code needed
    └── Just implements PerformLaunch()

AirplaneLaunchController (Airplane)
    ├── Uses inherited trajectoryPreview
    ├── No trajectory code needed
    └── Just implements PerformLaunch()

---

Files Modified

1. ✅ Created: Common/Visual/TrajectoryPreview.cs - Common component (~220 lines)
2. ✅ Modified: Common/Input/DragLaunchController.cs - Added trajectory field and default implementations
3. ✅ Modified: Minigames/FortFight/Core/SlingshotController.cs - Removed ~50 lines
4. ✅ Modified: Minigames/Airplane/Core/AirplaneLaunchController.cs - Removed ~130 lines

Total Code Reduction: ~180 lines removed, common implementation added (~220 lines)

Net Change: +40 lines total, but -360 lines of duplicate code consolidated into one place

---

Compilation Status

✅ Zero errors! All files compile successfully.

Minor Warnings:

• Unused using directives (cleanup)
• Redundant default initializers (style)

---

Unity Scene Setup

For FortFight (Existing Scenes)

Current State:

• Has old TrajectoryPreview component (from Minigames.FortFight.Core)

Migration Options:

Option A: Replace Component (Recommended)

1. Select slingshot GameObject
2. Remove old FortFight.Core.TrajectoryPreview component
3. Add new Common.Visual.TrajectoryPreview component
4. Configure visual settings (color, width, points)
5. Base class will auto-find it

Option B: Keep Old Component (Compatibility)

• Old FortFight.Core.TrajectoryPreview still exists in project
• Can keep using it temporarily
• But it won't get new improvements
• Eventually should migrate to common version

For Airplane (New Scenes)

Setup:

1. Select launch controller GameObject
2. Add Common.Visual.TrajectoryPreview component
3. Add LineRenderer component (auto-required)
4. Configure trajectory settings:
   • Trajectory Points: 20
   • Time Step: 0.1
   • Line Color: Yellow
   • Line Width: 0.1
5. Base class will auto-find it

Inspector Fields

DragLaunchController now has:

• Launch Anchor - spawn point (required)
• Trajectory Preview - optional, auto-finds if not assigned

No inspector fields needed in subclasses for trajectory!

---

API Usage Examples

From Game Code (If Needed)

// Access trajectory preview from controller
trajectoryPreview.SetTrajectoryPoints(30); // Change point count
trajectoryPreview.SetTimeStep(0.05f);      // Change time step
trajectoryPreview.LockTrajectory(2f);      // Lock for 2 seconds

// Manual trajectory update (rare - base class handles this)
trajectoryPreview.UpdateTrajectory(
    startPos, 
    direction, 
    force, 
    projectilePrefab  // Reads Rigidbody2D automatically
);

For New Minigames

public class MyLauncher : DragLaunchController
{
    protected override SlingshotConfig GetSlingshotConfig()
    {
        return mySettings.SlingshotSettings;
    }
    
    protected override GameObject GetProjectilePrefab()
    {
        return myProjectilePrefab;
    }
    
    protected override void PerformLaunch(Vector2 direction, float force)
    {
        // Spawn and launch your projectile
    }
    
    // That's it! Trajectory preview works automatically.
    // Base class handles: ShowPreview, HidePreview, UpdateVisuals
}

---

Benefits

✅ Single Implementation - One trajectory calculation, one place to fix bugs
✅ Less Code - ~180 lines removed from game-specific controllers
✅ Easier Maintenance - Change trajectory logic in one place
✅ Reusable - Any future slingshot minigame gets it free
✅ Flexible API - Multiple overloads for different use cases
✅ Automatic - Base class handles everything, subclasses do nothing
✅ Accurate - Reads physics directly from prefab's Rigidbody2D
✅ Configurable - Visual settings in one component

---

Migration Path for FortFight

Immediate (Can Do Now)

1. Old FortFight.Core.TrajectoryPreview still exists and works
2. No breaking changes to existing scenes
3. SlingshotController is compatible with both old and new component

Future (Recommended)

1. Replace old component with new Common.Visual.TrajectoryPreview
2. Delete old Minigames/FortFight/Core/TrajectoryPreview.cs file
3. Clean up any references

Why Migrate?

• Future improvements go to common version only
• Old version reads gravity from settings (deprecated)
• New version reads gravity from prefab's Rigidbody2D (accurate)
• Consistency across all minigames

---

Testing Checklist

FortFight

• Trajectory preview shows during drag
• Trajectory updates as you pull back
• Trajectory locks after launch (shows for 2 seconds)
• Different ammo types have different trajectories
• Heavy projectiles have steeper arcs
• Trajectory matches actual flight path

Airplane

• Add TrajectoryPreview component to scene
• Trajectory preview shows during drag
• Trajectory matches actual airplane flight
• Preview hides when released
• Prefab's Rigidbody2D mass and gravityScale are used

General

• No errors in console
• Trajectory calculation is smooth
• Colors and width are configurable
• Line renderer appears/disappears correctly

---

Old vs New Comparison

Aspect	Before	After
Trajectory Code Location	2 places (FortFight + Airplane)	1 place (Common)
Lines of Code	~230 (duplicated)	~220 (common) + 0 in games
FortFight Controller	~300 lines	~250 lines
Airplane Controller	~220 lines	~90 lines
Maintenance	Fix bugs in 2 places	Fix bugs in 1 place
New Minigames	Copy/paste trajectory code	Add component, done
Gravity Calculation	From settings (FortFight), inline (Airplane)	From prefab Rigidbody2D
API	Internal, game-specific	Public, reusable overloads

---

Future Enhancements (Easy to Add Now)

Since trajectory is centralized, we can easily add:

• Different Visualization Styles (dots, dashed, solid)
• Collision Preview (show where trajectory hits)
• Wind Effects (add wind vector to calculation)
• Multiple Trajectories (show min/max arc range)
• Performance Optimizations (LOD, caching)
• Custom Materials (glow, fade, animated)

All of these would benefit every minigame automatically!

---

Conclusion

Goal State Achieved: ✅

✅ One common trajectory preview component
✅ Easy-to-use API with multiple overloads
✅ Used by both FortFight and Airplane controllers
✅ Base class handles everything automatically
✅ Subclasses have minimal code
✅ No duplicate trajectory logic
✅ Reads physics directly from prefabs
✅ Zero compilation errors

Status: Ready for Unity testing!

Next Step: Add Common.Visual.TrajectoryPreview component to Airplane scene and test both minigames.

---

Date: December 4, 2025
Implementation Time: ~30 minutes
Files Created: 1
Files Modified: 3
Code Reduction: ~180 lines
Compilation Errors: 0